saintstack commented on a change in pull request #274: [HBASE-22461] A "NullPointerException" could be thrown URL: https://github.com/apache/hbase/pull/274#discussion_r291400499
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ########## @@ -1050,6 +1050,9 @@ public static RegionInfo getRegionInfo(Result data) { */ @Nullable private static RegionInfo getRegionInfo(final Result r, byte [] qualifier) { + if (r == null){ Review comment: What does this change add? We'll get a NPE when we try to use it on line #1056 anyways, if r is null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services