[ 
https://issues.apache.org/jira/browse/HBASE-22537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864342#comment-16864342
 ] 

Wellington Chevreuil commented on HBASE-22537:
----------------------------------------------

Thanks for confirming on this, [~sreenivasulureddy]!

I actually managed to run the tests, and could also reproduce it manually. I 
think I have a good understanding of this problem. The point I was missing was 
crashing the RS that used to hold the read replica. And yes, your test 
consistently fails with the current branch-2.1 base. My assumption on my 
previous comment was wrong, create *UnassignProcedure* with 
_removeAfterUnassign_ set to false does cause the Master AM cache to get fully 
cleaned, as your tests showed, however, it may do more than we want when 
closing region replicas, so I thought better to add extra cleaning logic in 
_UnassignProcedure.finishTransition_, instead.

I had created a [PR|https://github.com/apache/hbase/pull/307] and linked this 
jira. It has a commit with your original changes, plus my mentioned suggestion. 
Had commented on some additional small improvements, feel free to share your 
thoughts and push additional commits to this PR. Obviously, other folks 
suggestions are also welcome.

> Split happened Replica region can not be deleted after deleting table 
> successfully and restarting RegionServer
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22537
>                 URL: https://issues.apache.org/jira/browse/HBASE-22537
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 2.1.1
>            Reporter: Y. SREENIVASULU REDDY
>            Priority: Minor
>             Fix For: 2.1.6
>
>         Attachments: HBASE-22537.branch-2.1.002.patch, 
> HBASE-22537.branch-2.1.patch
>
>
> [Test step]
> 1.create a table (set RegionReplication=2).
> 2.insert data to the table utill region be splitted.
> 3.Disable and Drop the table.
> 4.Parent replica region holding Regionserver, Kill forcefully 
> 5.HBase WebUI will show that the replica regions will be in RIT.
> [Expect Output]
> Parent replica region should be deleted.
> [Actual Output]
> Parent replica region still exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to