[
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239639#comment-13239639
]
Jonathan Hsieh commented on HBASE-5598:
---------------------------------------
bq. Sure, I will update the patch in HBASE-5642. But regarding updating the
count, I am not agreeing. I am planning to use exclude filter file to exclude
the invalid bugs. Please see the discussion in HBASE-5597 about updating the
count. Please correct me if i understood wrongly your question. Thanks a lot.
Here's what I'm suggesting. Eventually we set the number to 0 due to the
excludes files. Meanwhile, as we commit exclude/fix these warnings patches, we
update the count to the number you expect to see after the patch. Patches in
flight would just see the same number of new warnings it introduced instead of
warnings from disappearing as you mentioned in HBASE-5597.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the
> invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
