[ https://issues.apache.org/jira/browse/HBASE-22090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874105#comment-16874105 ]
Hudson commented on HBASE-22090: -------------------------------- Results for branch branch-2 [build #2029 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2029/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2029//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2029//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2029//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > The HFileBlock#CacheableDeserializer should pass ByteBuffAllocator to the > newly created HFileBlock > -------------------------------------------------------------------------------------------------- > > Key: HBASE-22090 > URL: https://issues.apache.org/jira/browse/HBASE-22090 > Project: HBase > Issue Type: Sub-task > Reporter: Zheng Hu > Assignee: Zheng Hu > Priority: Major > Attachments: HBASE-22090.HBASE-21879.v01.patch, > HBASE-22090.HBASE-21879.v02.patch, HBASE-22090.HBASE-21879.v03.patch > > > In HBASE-22005, we have the following TODO in > HFileBlock#CacheableDeserializer: > {code} > public static final class BlockDeserializer implements > CacheableDeserializer<Cacheable> { > private BlockDeserializer() { > } > @Override > public HFileBlock deserialize(ByteBuff buf, boolean reuse, MemoryType > memType) > throws IOException { > // .... > // TODO make the newly created HFileBlock use the off-heap allocator, > Need change the > // deserializer or change the deserialize interface. > return new HFileBlock(newByteBuff, usesChecksum, memType, offset, > nextBlockOnDiskSize, null, > ByteBuffAllocator.HEAP); > } > {code} > Should use the global ByteBuffAllocator here rather than HEAP allocator, as > the TODO said, we need to adjust the interface of deserializer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)