gjacoby126 commented on issue #352: HBASE-22622 - WALKey Extended Attributes URL: https://github.com/apache/hbase/pull/352#issuecomment-509390346 @apurtell @saintstack @Apache9 - adding extended attributes to WALKey as discussed in HBASE-22622. I wasn't able to use a protobuf map class because the "public" protobuf version doesn't support it so it wouldn't be backwards compatible, so I went back to @apurtell 's original suggestion of a repeated key/value attribute. Keys are strings rather than bytes because Java uses reference equality for hashmaps with byte[] keys, and it seemed better than littering the code with ByteBuffers or ImmutableBytesWritable everywhere. I've fixed the checkstyle issues, and the test failures appear to be flapping replication tests (each run gives different results even when only trivial formatting changes have been made) Related coprocessor changes will be in HBASE-22623, unless the community feels it would be better to consolidate the two patches. Thanks for taking a look!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
