busbey commented on a change in pull request #360: HBASE-15666 shaded 
dependencies for hbase-testing-util
URL: https://github.com/apache/hbase/pull/360#discussion_r301700356
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -2257,6 +2257,7 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
+      <scope>test</scope>
 
 Review comment:
   previously this caused issues with our assembly, because the ITs relied on 
it in order to run against a live cluster or standalone instance. please make 
sure that still works. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to