virajjasani commented on a change in pull request #371: HBASE-22648 :
Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303452338
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1445,6 +1445,9 @@
"hbase.util.default.lossycounting.errorrate";
public static final String NOT_IMPLEMENTED = "Not implemented";
+ // Default Snapshot TTL - 30 days (good enough?)
+ public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
Review comment:
@petersomogyi @Reidddddd Thanks for your opinions. Can we have a new config?
Say if **hbase.master.snapshot.apply.default.cleaner** is present with value
"true", then any new snapshot created without TTL should have default TTL of 30
days applied. If the config is "false" or not present, and if user doesn't
specify TTL, snapshot will be retained forever.
(default value of **hbase.master.snapshot.apply.default.cleaner** in
default-site would be false)
I can incorporate this if you agree with this new config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
