[
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886347#comment-16886347
]
Geoffrey Jacoby edited comment on HBASE-22623 at 7/16/19 5:57 PM:
------------------------------------------------------------------
I think Append and Increment use a different code path (see HRegion.doDelta)
and so would have to be instrumented a different way, perhaps with extra
coprocessor hooks, one for Increment and one for Append. (The existing Append
and Increment pre-hooks don't take a convenient "carrier" object like the batch
mutations do, and already use their return values for other purposes.)
checkAndXXX seems to eventually go down the same batch mutation path as Puts
and Deletes (see HRegion:4287) so the MiniBatchOperationInProgress solution
above would work for them.
They're mostly unrelated changes though, so it would either work to do them
together in this JIRA or separately.
was (Author: gjacoby):
I think Append and Increment use a different code path (see HRegion.doDelta)
and so would have to be instrumented a different way, perhaps with extra
coprocessor hooks, one for Increment and one for Append. (The existing Append
and Increment pre-hooks don't take a convenient "carrier" object like the batch
mutations do, and already use their return values for other purposes.)
checkAndXXX seems to eventually go down the same batch mutation path (see
HRegion:4287) so the MiniBatchOperationInProgress solution above would work for
them.
They're mostly unrelated changes though, so it would either work to do them
together in this JIRA or separately.
> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
> Key: HBASE-22623
> URL: https://issues.apache.org/jira/browse/HBASE-22623
> Project: HBase
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs,
> there aren't any that expose the WALKey before it's created and added to the
> WALEntry.
> It's sometimes useful for coprocessors to be able to edit the WALKey, for
> example to add extended attributes using the fields to be added in
> HBASE-22622.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
