[ 
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886378#comment-16886378
 ] 

Geoffrey Jacoby commented on HBASE-22623:
-----------------------------------------

What I meant is that for ease of evaluation and to keep patches at a modest 
size, instrumentation for the two code paths could be done in separate JIRAs, a 
new one for Append + Increment and this one for Batch Mutate. Both would need 
to be done to get full coverage, and we'd want them in the same release. 
(Phoenix does use Append and Increment in a few cases, such as atomic upserts.) 

I can also combine them in this JIRA, which it sounds like you'd prefer and 
would also be fine. 

The signatures for the Append/Increment coprocs and the Batch mutation coprocs 
are different enough that I'm somewhat skeptical we could make a single hook 
that would work for both, and doing the batch mutation instrumentation through 
the MiniBatchOperationInProgress eliminates the need for new coprocessor hooks 
on that path, and limiting those to a minimum (such as the 
seemingly-unavoidable ones on Append and Increment) seems good to me. 

> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
>                 Key: HBASE-22623
>                 URL: https://issues.apache.org/jira/browse/HBASE-22623
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs, 
> there aren't any that expose the WALKey before it's created and added to the 
> WALEntry. 
> It's sometimes useful for coprocessors to be able to edit the WALKey, for 
> example to add extended attributes using the fields to be added in 
> HBASE-22622. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to