[ 
https://issues.apache.org/jira/browse/HBASE-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241452#comment-13241452
 ] 

Jonathan Hsieh commented on HBASE-5599:
---------------------------------------

Thanks for updating the patches.

Instead of relying on shouldFixAssignments, could you add a new config flag for 
fixing the NO_VERSION_FILE? The fix isn't really a region assignment fix!  
Maybe call it -fixVersionFile, and have it on with the combo '-repair*' 
options? 

Can you add a test case for SHOULD_NOT_BE_DEPLOYED?  You should be able to hack 
one of the test cases from TestHBaseFsck.  I've had problems just using assign 
before so if tests come back failing, you may want to try 
HBaseFsckRepair.fixMultiAssignemnt or tryAssignemntRepair.

The merge addition isn't really related -- was its inclusion intended?
                
> The hbck tool can not fix the six scenarios, it is NO_VERSION_FILE, 
> NOT_IN_META_OR_DEPLOYED, NOT_IN_META, SHOULD_NOT_BE_DEPLOYED, 
> FIRST_REGION_STARTKEY_NOT_EMPTY, HOLE_IN_REGION_CHAIN.
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5599
>                 URL: https://issues.apache.org/jira/browse/HBASE-5599
>             Project: HBase
>          Issue Type: New Feature
>          Components: hbck
>    Affects Versions: 0.90.6
>            Reporter: fulin wang
>             Fix For: 0.90.6
>
>         Attachments: hbase-5599-0.90.patch, hbase-5599-0.90_v2.patch, 
> hbase-5599-0.90_v3.patch, hbase-5599-0.90_v5.patch, hbase-5599-0.92_v5.patch, 
> hbase-5599-0.94_v5.patch, hbase-5599-trunk_v5.patch
>
>
> The hbck tool can not fix the six scenarios.
> 1. Version file does not exist in root dir.
>    Fix: I try to create a version file by 'FSUtils.setVersion' method.
>    
> 2. [REGIONNAME][KEY] on HDFS, but not listed in META or deployed on any 
> region server.
>    Fix: I get region info form the hdfs file, this region info write to 
> '.META.' table.
>    
> 3. [REGIONNAME][KEY] not in META, but deployed on [SERVERNAME]
>    Fix: I get region info form the hdfs file, this region info write to 
> '.META.' table.
>    
> 4. [REGIONNAME] should not be deployed according to META, but is deployed on 
> [SERVERNAME]
>    Fix: Close this region.
>    
> 5. First region should start with an empty key.  You need to  create a new 
> region and regioninfo in HDFS to plug the hole.
>    Fix: The region info is not in hdfs and .META., so it create a empty 
> region for this error.
> 6. There is a hole in the region chain between [KEY] and [KEY]. You need to 
> create a new regioninfo and region dir in hdfs to plug the hole.
>   Fix: The region info is not in hdfs and .META., so it create a empty region 
> for this hole.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to