[ https://issues.apache.org/jira/browse/HBASE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241942#comment-13241942 ]
Zhihong Yu commented on HBASE-5655: ----------------------------------- Patch looks good. Minor comment: {code} +# In case one need to do log {code} The above should read 'one needs to ...' The 2 of the test failures should have been fixed by MAPREDUCE-3583. > Cap space usage of default log4j rolling policy > ----------------------------------------------- > > Key: HBASE-5655 > URL: https://issues.apache.org/jira/browse/HBASE-5655 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.92.1 > Reporter: Himanshu Vashishtha > Assignee: Himanshu Vashishtha > Attachments: 5655-v1.patch, HBase-5655-v2.patch > > > The current default log4j policy is to use Daily Rolling File Appender > (DRFA). At times, its good to have a cap on the maximum size of the logs in > order to limit its disk usage. Here is a proposal to set a new file appemder > (RFA) as the default appender. It can be configured via env so that existing > tools can use the current behavior of using DRFA instead. > This is in parallel with jira Hadoop-8149. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira