[ https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896607#comment-16896607 ]
Andrew Purtell commented on HBASE-22762: ---------------------------------------- Looks like you fail to print the first entry in the journal. Ordering is weird. Have: {noformat} 1102 PONR at 1564524100423 (81ms) 1103 OPENED_REGION_A at 1564524100504 (0ms) 1104 OPENED_REGION_B at 1564524100504 (114ms) {noformat} Should be: {noformat} 1102 PONR at 1564524100423 (81ms) 1103 OPENED_REGION_A at 1564524100504 (114ms) 1104 OPENED_REGION_B at 1564524100504 (0ms) {noformat} Consider putting a space between the number and the time unit, like: {noformat} 1100 STARTED_REGION_A_CREATION at 1564524100389 (20 ms) {noformat} The time in parenthesis is a delta so use a '+' to indicate it is a delta, like: {noformat} 1100 STARTED_REGION_A_CREATION at 1564524100389 (+20 ms) {noformat} When there is no difference, don't print anything, like: {noformat} 1102 PONR at 1564524100423 (+14 ms) 1103 OPENED_REGION_A at 1564524100504 (+81 ms) 1104 OPENED_REGION_B at 1564524100504 1105 BEFORE_POST_SPLIT_HOOK at 1564524100618 (+114 ms) {noformat} Example above corrected with correct deltas > Print the delta between phases in the split/merge/compact/flush transaction > journals > ------------------------------------------------------------------------------------ > > Key: HBASE-22762 > URL: https://issues.apache.org/jira/browse/HBASE-22762 > Project: HBase > Issue Type: Improvement > Components: logging > Reporter: Andrew Purtell > Assignee: Xu Cang > Priority: Minor > Attachments: HBASE-22762.branch-1.001.patch, > HBASE-22762.branch-1.002.patch > > > We print the start timestamp for each phase when logging the > split/merge/compact/flush transaction journals and so when debugging an > operator must do the math by hand. It would be trivial to also print the > delta from the start timestamp of the previous phase and helpful to do so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)