[
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900506#comment-16900506
]
Andrew Purtell edited comment on HBASE-22623 at 8/6/19 12:59 AM:
-----------------------------------------------------------------
bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit)
<scream.gif>
:-)
I don't think immutable WALedits buy us anything, but I was not the one who did
the refactor of the WAL interface so don't have the context. [~busbey] might
you point us in the right direction?
In my opinion we decorate WALedits with special cells, the compaction marker
etc., and a coprocessor may want to do this too. Although it does not do so
today I am thinking especially of Phoenix. We did consider special cells
instead of WALkey attributes for HBASE-22622. Turns out special cells wouldn't
work there but, now that we are adding a hook where a coprocessor can get
control to decorate the key, we should include coverage for decorating/mutating
the edit as well, or I fear this will be a miss later when someone needs it.
was (Author: apurtell):
bq. WALEdit preWALAppend(WALKey, WALEditSuperInterfaceWithoutAddMethods edit)
<scream.gif>
:-)
I don't think immutable WALedits buy us anything, but I was not the one who did
the refactor of the WAL interface so don't have the context. [~busbey] might
you point us in the right direction?
In my opinion we decorate WALedits with special cells, the compaction marker
etc., and a coprocessor may want to do this too. Although it does not do so
today I am thinking especially of Phoenix. We did consider special cells
instead of WALkey attributes for HBASE-22622. Now that we are adding a hook
where a coprocessor can get control to decorate the key, we should include
coverage for decorating/mutating the edit as well, or I fear this will be a
miss later when someone needs it.
> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
> Key: HBASE-22623
> URL: https://issues.apache.org/jira/browse/HBASE-22623
> Project: HBase
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs,
> there aren't any that expose the WALKey before it's created and added to the
> WALEntry.
> It's sometimes useful for coprocessors to be able to edit the WALKey, for
> example to add extended attributes using the fields to be added in
> HBASE-22622.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
