[ 
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902234#comment-16902234
 ] 

Andrew Purtell commented on HBASE-22623:
----------------------------------------

I have to agree. I can call System.exit() from a coprocessor. That doesn't mean 
it is a good idea. A necessary precondition for coprocessor API use is an 
understanding you are messing with internals. It's not meant for arbitrary user 
code or user development. We don't need to protect against dumb users. What we 
can/should protect is our ability to change LP(coproc) interfaces, so if there 
is a concern there that would certainly be valid. However these classes - 
WALKey and WALEdit are both already LP(coproc). I think [~Apache9]'s position 
is not reasonable, but he is entitled to his opinion. I hope he will consider 
changing it, though. 



> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
>                 Key: HBASE-22623
>                 URL: https://issues.apache.org/jira/browse/HBASE-22623
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs, 
> there aren't any that expose the WALKey before it's created and added to the 
> WALEntry. 
> It's sometimes useful for coprocessors to be able to edit the WALKey, for 
> example to add extended attributes using the fields to be added in 
> HBASE-22622. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to