apurtell commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r311703256
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
##########
@@ -48,15 +48,12 @@
* Used in HBase's transaction log (WAL) to represent a collection of edits
(Cell/KeyValue objects)
* that came in as a single transaction. All the edits for a given transaction
are written out as a
* single record, in PB format, followed (optionally) by Cells written via the
WALCellEncoder.
- * <p>This class is LimitedPrivate for CPs to read-only. The {@link #add}
methods are
- * classified as private methods, not for use by CPs.</p>
* <p>WALEdit will accumulate a Set of all column family names referenced by
the Cells
* {@link #add(Cell)}'d. This is an optimization. Usually when loading a
WALEdit, we have the
* column family name to-hand.. just shove it into the WALEdit if available.
Doing this, we can
* save on a parse of each Cell to figure column family down the line when we
go to add the
* WALEdit to the WAL file. See the hand-off in FSWALEntry Constructor.
*/
-// TODO: Do not expose this class to Coprocessors. It has set methods. A CP
might meddle.
Review comment:
Same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
