[ https://issues.apache.org/jira/browse/HBASE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243616#comment-13243616 ]
stack edited comment on HBASE-5688 at 4/1/12 12:18 AM: ------------------------------------------------------- Changes the content of the root location znode, root-region-server, to be four magic bytes ('PBUF') followed by a protobuf message that holds the ServerName of the server currently hosting root. {code} D src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java Removed. Had two methods, one to add root-region-server znode and another to removed it. Rather, put these methods in RootRegionTracker. It tracks root-region-server znode. Having all to do w/ root-region-server is more cohesive. Also makes it so can encapsulate in one class all to do w/ create, delete, and reading of root-region-server. We also want to purge the catalog package (See note at head of CatalogTracker). M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Get root region location from RootRegionTracker rather than from RootLocationEditor. A src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java Utility to do w/ protobuf handling. Has methods to help prefixing and stripping from serialized protobuf messages some 'magic'. A src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java PB generated. M src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java Use new RootRegionTracker method for getting content of znode rather than do it all here (going via RootRegionTracker, we can keep how the znode content is serialized private to the RootRegionTracker class. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Has the methods that used to be in RootLocationEditor plus a new getRootRegionLocation method (does not set watcher). A src/main/protobuf/ZooKeeper.proto M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java M src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java Get root region location from RootRegionTracker rather than from RootLocationEditor. A src/test/java/org/apache/hadoop/hbase/zookeeper/TestRootRegionTracker.java Test of dataToServerName method in RootRegionTracker. {code} was (Author: stack): Changes the content of the root location znode, root-region-server, to be four magic bytes ('PBUF') followed by a protobuf message that holds the ServerName of the server currently hosting root. D src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java Removed. Had two methods, one to add root-region-server znode and another to removed it. Rather, put these methods in RootRegionTracker. It tracks root-region-server znode. Having all to do w/ root-region-server is more cohesive. Also makes it so can encapsulate in one class all to do w/ create, delete, and reading of root-region-server. We also want to purge the catalog package (See note at head of CatalogTracker). M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Get root region location from RootRegionTracker rather than from RootLocationEditor. A src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java Utility to do w/ protobuf handling. Has methods to help prefixing and stripping from serialized protobuf messages some 'magic'. A src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java PB generated. M src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java Use new RootRegionTracker method for getting content of znode rather than do it all here (going via RootRegionTracker, we can keep how the znode content is serialized private to the RootRegionTracker class. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Has the methods that used to be in RootLocationEditor plus a new getRootRegionLocation method (does not set watcher). A src/main/protobuf/ZooKeeper.proto M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java M src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java M src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java Get root region location from RootRegionTracker rather than from RootLocationEditor. A src/test/java/org/apache/hadoop/hbase/zookeeper/TestRootRegionTracker.java Test of dataToServerName method in RootRegionTracker. > Convert zk root-region-server znode content to pb > ------------------------------------------------- > > Key: HBASE-5688 > URL: https://issues.apache.org/jira/browse/HBASE-5688 > Project: HBase > Issue Type: Task > Reporter: stack > Assignee: stack > Fix For: 0.96.0 > > Attachments: 5688.txt, 5688v4.txt > > > Move the root-region-server znode content from the versioned bytes that > ServerName.getVersionedBytes outputs to instead be pb. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira