openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312767928
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketEntry.java
##########
@@ -194,7 +194,10 @@ boolean isRpcRef() {
}
Cacheable wrapAsCacheable(ByteBuffer[] buffers) throws IOException {
- ByteBuff buf = ByteBuff.wrap(buffers, this.refCnt);
+ return wrapAsCacheable(ByteBuff.wrap(buffers, this.refCnt));
+ }
+
+ Cacheable wrapAsCacheable(ByteBuff buf) throws IOException {
Review comment:
That's a good thing, make the wrapAsCacheable into two methods. the
SharedIOEngine use the former one, and the ExclusiveIOEngine use the later
one. Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
