Reidddddd edited a comment on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520290804 IIRC, `gracefully_stop.sh` will turn balancer off, move regions, stop/restart RS, then turn balancer on. And there's one script `rolling_restart.sh` relying on `gracefully_stop.sh`, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level. One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty. I incline to keep it still, and so, leave my -0.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
