[ 
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906821#comment-16906821
 ] 

Reid Chan commented on HBASE-22774:
-----------------------------------

Checked master branch and branch-2.x.
They look good, because wal is got from {{rs.getWAL(regionInfo)}}
{code:title=AssignRegionHandler.java|borderStyle=solid}
    try {
      TableDescriptor htd =
        tableDesc != null ? tableDesc : 
rs.getTableDescriptors().get(regionInfo.getTable());
      if (htd == null) {
        throw new IOException("Missing table descriptor for " + regionName);
      }
      // pass null for the last parameter, which used to be a 
CancelableProgressable, as now the
      // opening can not be interrupted by a close request any more.
      region = HRegion.openHRegion(regionInfo, htd, rs.getWAL(regionInfo), 
rs.getConfiguration(),
        rs, null);
    } catch (IOException e) {
      cleanUpAndReportFailure(e);
      return;
    }
{code}

> [WAL] RegionGroupingStrategy loses its function after split
> -----------------------------------------------------------
>
>                 Key: HBASE-22774
>                 URL: https://issues.apache.org/jira/browse/HBASE-22774
>             Project: HBase
>          Issue Type: Bug
>          Components: Performance, wal
>    Affects Versions: 1.4.6
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>            Priority: Major
>         Attachments: HBASE-22774.branch-1.001.patch, 
> HBASE-22774.branch-1.002.patch
>
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver 
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her 
> parent's WAL, which violates the setting. For example, when 
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions 
> should create its own WAL instead of inheriting. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to