openinx commented on a change in pull request #493: HBASE-22833
MultiRowRangeFilter should provide a method for creating…
URL: https://github.com/apache/hbase/pull/493#discussion_r314153523
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
##########
@@ -71,6 +72,22 @@ public MultiRowRangeFilter(List<RowRange> list) {
this.ranges = new RangeIteration(rangeList);
}
+ /**
+ * @param rowKeyPrefixes the array of byte array
Review comment:
I think we need a careful javadoc here, say why we need the public method
... because exposing an MultiRowRangeFilter constructor with rowKeyPrefixes
looks very strange if no doc here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
