virajjasani commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314990427
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -87,15 +90,15 @@ public static Throwable findException(Object exception) {
}
Throwable cur = (Throwable) exception;
while (cur != null) {
- if (isSpecialException(cur)) {
+ if (matchExceptionWeCare(cur)) {
Review comment:
Agree it should have meaningful name. I was thinking rather than
`matchExceptionWeCare` which might not be a generic method nor meaningful, is
it fine to write this directly? :
```
if(regionDefinitelyOnTheRegionServerException(cur) ||
regionServerIsOverloadException(cur) || cur instanceof
NotServingRegionException)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
