[jira] [Commented] (HBASE-22872) Don't create normalization plan unnecesarily when split and merge both are disabled

[Reid Chan (Jira)]

    [ 
https://issues.apache.org/jira/browse/HBASE-22872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912147#comment-16912147
 ] 

Reid Chan commented on HBASE-22872:
-----------------------------------

LGTM overall, few nits:

space between if and {

{code:java}
if(!splitEnabled*
{code}

Can we just keep the line separation style? Usually, don't start with '.'
{code}
splitEnabled = masterRpcServices.isSplitOrMergeEnabled(null,
  
RequestConverter.buildIsSplitOrMergeEnabledRequest(MasterSwitchType.SPLIT)).getEnabled();
{code}



> Don't create normalization plan unnecesarily when split and merge both are 
> disabled
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-22872
>                 URL: https://issues.apache.org/jira/browse/HBASE-22872
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.4.10
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Minor
>         Attachments: HBASE-22872.branch-1.4.001.patch, 
> HBASE-22872.branch-1.4.002.patch
>
>
> We should not proceed futher in normalization plan creation if split and 
> merge both are disabled on a table.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)