Apache-HBase commented on issue #527: HBASE-22880 Move the DirScanPool out and do not use static field URL: https://github.com/apache/hbase/pull/527#issuecomment-524255238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 105 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 508 | branch-1 passed | | +1 | compile | 42 | branch-1 passed with JDK v1.8.0_222 | | +1 | compile | 44 | branch-1 passed with JDK v1.7.0_232 | | +1 | checkstyle | 94 | branch-1 passed | | +1 | shadedjars | 183 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | branch-1 passed with JDK v1.8.0_222 | | +1 | javadoc | 41 | branch-1 passed with JDK v1.7.0_232 | | 0 | spotbugs | 178 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 171 | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 118 | the patch passed | | +1 | compile | 40 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 40 | the patch passed | | +1 | compile | 44 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 44 | the patch passed | | -1 | checkstyle | 94 | hbase-server: The patch generated 5 new + 255 unchanged - 5 fixed = 260 total (was 260) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 167 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 292 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 29 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 38 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 167 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11052 | hbase-server in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 13526 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hbase.client.TestAdmin2 | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/527 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fb7e0cfeacd1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh | | git revision | branch-1 / bb87e3a | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/testReport/ | | Max. process+thread count | 5189 (vs. ulimit of 10000) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services