busbey commented on a change in pull request #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies. URL: https://github.com/apache/hbase/pull/525#discussion_r317251952
########## File path: dev-support/jenkins-scripts/cache-apache-project-artifact.sh ########## @@ -123,6 +123,12 @@ if [ -n "${keys}" ]; then echo "signature good." fi +if [ -n "${keys}" ]; then Review comment: this should be placed up in the clean up handler function. that way if e.g. we run into a problem before here but after our first command launches a gpg-agent we'll still clean up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services