Apache-HBase commented on issue #537: HBASE-22883 Duplacate codes of method Threads.newDaemonThreadFactory(… URL: https://github.com/apache/hbase/pull/537#issuecomment-525199430 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 310 | master passed | | +1 | compile | 134 | master passed | | +1 | checkstyle | 136 | master passed | | +1 | shadedjars | 268 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 88 | master passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 333 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 301 | the patch passed | | +1 | compile | 136 | the patch passed | | +1 | javac | 136 | the patch passed | | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-common | | +1 | checkstyle | 80 | hbase-server: The patch generated 0 new + 60 unchanged - 3 fixed = 60 total (was 63) | | +1 | checkstyle | 15 | The patch passed checkstyle in hbase-backup | | +1 | checkstyle | 16 | The patch passed checkstyle in hbase-it | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 927 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 88 | the patch passed | | +1 | findbugs | 344 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 183 | hbase-common in the patch passed. | | +1 | unit | 8982 | hbase-server in the patch passed. | | +1 | unit | 876 | hbase-backup in the patch passed. | | +1 | unit | 67 | hbase-it in the patch passed. | | +1 | asflicense | 122 | The patch does not generate ASF License warnings. | | | | 14217 | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-537/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/537 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4e732f5caca1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-537/out/precommit/personality/provided.sh | | git revision | master / c88267202a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-537/3/testReport/ | | Max. process+thread count | 5189 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-server hbase-backup hbase-it U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-537/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
