apurtell commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-525520936 I second the concern about the custom terminal library. I backported a previous version of this patch to a branch-1 based codebase to try it out (and to review it), but the result both resizes the terminal unexpectedly and aborts with the below exception. Now, I'm not saying this is a problem in the patch on the PR per se, but if it is, or some future change breaks the terminal library, do we want to support these kinds of issues? Now let me go over the latest rev of this patch and try to figure out where I've gone wrong.... Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 34 at org.apache.hadoop.hbase.hbtop.terminal.impl.ScreenBuffer.endOfLine(ScreenBuffer.java:164) at org.apache.hadoop.hbase.hbtop.terminal.impl.TerminalPrinterImpl.endOfLine(TerminalPrinterImpl.java:79) at org.apache.hadoop.hbase.hbtop.screen.top.TopScreenView.showSummary(TopScreenView.java:219) at org.apache.hadoop.hbase.hbtop.screen.top.TopScreenView.showTopScreen(TopScreenView.java:210) at org.apache.hadoop.hbase.hbtop.screen.top.TopScreenPresenter.refresh(TopScreenPresenter.java:95) at org.apache.hadoop.hbase.hbtop.screen.top.TopScreenView.init(TopScreenView.java:66) at org.apache.hadoop.hbase.hbtop.screen.Screen.run(Screen.java:78) at org.apache.hadoop.hbase.hbtop.HBTop.run(HBTop.java:126) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at org.apache.hadoop.hbase.hbtop.HBTop.main(HBTop.java:137)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
