brfrn169 commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-525581706 On the Stack's first concern (that we should use a 3rd party terminal/libs instead of writing our own), I think we should use a terminal lib to avoid reinventing the wheel ideally. And as Andrew mentioned, we don't want to support that kinds of issues. Although I couldn't find a good terminal lib at the first try, I can retry to do that. Should I do it before it's committed? Or as a new issue after it's committed? On the second concern (whether it should be out in hbase-operator-tools or committed into hbase), if we commit it to hbase-operator-tools, I have several concerns. I want to make it available for not only branch-2+ but also branch-1. If we commit it to hbase-operator-tools, how do we manage the codes for the different versions? We need to create branches in hbase-operator-tools for the HBase versions? Also, I want to add metrics to hbtop after it's committed. To do this, I will first need to add the metrics to ClusterMetrics in the HBase main project, and then add to hbtop itself. In this case, I think we will need to do release management in hbase-operator-tools as other hbase ecosystems like Phoenix do. Is this correct? For example, let's see we add some metrics to ClusterMetrics in hbase-2.1.6 and add the metrics to hbtop. After that, if we run the latest hbtop against hbase-2.1.5, it will crash because ClusterMetrics in hbase-2.1.5 doesn't have the additional metrics yet. So in this case, I think we need to create release tags for hbase-2.1.5 and hbase-2.1.6 in hbase-operator-tools, and need to run hbtop in a proper tag against the hbase version. I think HBCK2 also has this kind of issue potentially. But, I might be wrong. If so, please correct me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
