johnhomsea commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r318953211
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -59,18 +58,23 @@ public static boolean isMetaClearingException(Throwable
cur) {
if (cur == null) {
return true;
}
- return !isSpecialException(cur) || (cur instanceof RegionMovedException)
- || cur instanceof NotServingRegionException;
+ return !regionLocationIsConsistentWithServerException(cur);
}
- public static boolean isSpecialException(Throwable cur) {
- return (cur instanceof RegionMovedException || cur instanceof
RegionOpeningException
- || cur instanceof RegionTooBusyException || cur instanceof
RpcThrottlingException
- || cur instanceof MultiActionResultTooLarge || cur instanceof
RetryImmediatelyException
- || cur instanceof CallQueueTooBigException || cur instanceof
CallDroppedException
- || cur instanceof NotServingRegionException || cur instanceof
RequestTooBigException);
+ public static boolean regionServerIsOverloadException(Throwable t) {
+ return t instanceof CallQueueTooBigException || t instanceof
CallDroppedException;
}
+ private static boolean
regionLocationIsConsistentWithServerException(Throwable t) {
Review comment:
I find a UT function named metaCachePreservingExceptions in class
TestMetaCache with similar meanings, so here I rename to
isMetaCachePreservingException. What do you think about that, sir?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
