shahrs87 commented on a change in pull request #565: [HBASE-22874] Canary
should not be IA.Public
URL: https://github.com/apache/hbase/pull/565#discussion_r319691668
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
##########
@@ -1629,7 +1684,7 @@ public static void main(String[] args) throws Exception {
final Configuration conf = HBaseConfiguration.create();
// Loading the generic options to conf
- new GenericOptionsParser(conf, args);
+ //new GenericOptionsParser(conf, args);
Review comment:
This was redundant. We already do parsing in
https://github.com/apache/hadoop/blob/branch-2.8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ToolRunner.java#L70
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
