ankitsinghal commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320039443
########## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ########## @@ -88,6 +100,10 @@ private static final String VERSION = "version"; private static final String SET_REGION_STATE = "setRegionState"; private static final String SCHEDULE_RECOVERIES = "scheduleRecoveries"; + private static final String ADD_MISSING_REGIONS_IN_META_FOR_TABLES = + "addMissingRegionsInMetaForTables"; + private static final String ADD_MISSING_REGIONS_IN_META = "addMissingRegionsInMeta"; + private static final String REPORT_MISSING_REGIONS_IN_META = "reportMissingRegionsInMeta"; Review comment: Can we make it like other options in hbck2 , instead of three. Like ` meta [OPTIONS] [<TABLENAME>...]` if option -f /--fix is passed, then fix the missing Meta regions otherwise report only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
