[ 
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246736#comment-13246736
 ] 

Jean-Daniel Cryans commented on HBASE-5716:
-------------------------------------------

bq. should we roll on number of edits or size of the file?

Number of edits is rarely good, you always end up with someone with a 
degenerate case that has values MBs big so we should stick to the file size. 
Rolling on the uncompressed size would be good because then we keep the same 
behavior but this is going to be at the expense more code to keep track of it. 
Rolling on the actual size with compression turned on could make system behave 
differently for good or worse, I'm not sure which.
                
> Make HBASE-4608 easier to use
> -----------------------------
>
>                 Key: HBASE-5716
>                 URL: https://issues.apache.org/jira/browse/HBASE-5716
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Li Pi
>             Fix For: 0.96.0, 0.94.1
>
>
> HBASE-4608 is a nice feature but after playing with it for a while I think 
> the following should be fixed to make it easier to use by someone who's not a 
> dev:
>  - Add some signal that says that the feature is turned on. Right now you can 
> {{jstack | grep KeyValueCompression}} a couple of times and if you get a hit 
> you definitely know it's on, but otherwise the random user wouldn't know 
> without going through the jira.
>  - Add documentation in the reference guide. At the minimum add 
> {{hbase.regionserver.wal.enablecompression}} in there with a small 
> description. Better would be to add a section in {{Appendix B}} or something 
> like that and describe the functionality a bit and who it's useful for. For 
> example, flush from your brain the knowledge of the patch and read the name 
> of the configuration... now let's say you have a use case that involves 
> writing easily compressible values. Any normal user would believe that this 
> is a good tuning parameter for them, but it's just going to waste CPU cycles.
>  - Add some metrics like we have for HFiles where you get a clue about the 
> compression ratio.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to