anoopsjohn commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r320564397
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##########
@@ -242,6 +245,17 @@ public int compare(BlockCacheKey a, BlockCacheKey b) {
/** In-memory bucket size */
private float memoryFactor;
+ private String[] filePaths;
Review comment:
getFilePaths() in IOEngine? That seems strange. The IOEngine need not be
file backed always right? Can we have a way in IOEngine to do this checksum
calc and write as well as verification within the specific IOE impl class?
(Rather than in BucketCache). We have FileMmapIOE also which also needs this
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
