openinx commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-527795557 I think @chenxu14 have tried to accomplish the patch in some eailier patch version ( says just ignore the RPC reference when freeEntireBuckets for exclusive io engine case). What I concern before is: we're freeing some referenced block in exclusive IO engine, seems it's volidating the LRU policy. Reconsider the case, for exclusive IO engine, free the memory area in bucket allocator should be OK. Compared to the buggy CompositeRefCnt (Not say the current version have bug but say it's an more complex implementation and easy to introduce new bugs), sacrificing some LRU attribution in rare cases should also be acceptable. I mean we need to balance between them, maybe we can still try the patch without CompositeRefCnt. (@chenxu14 , I've tried to contact you in your meituan email address serveral times but seems no response or failed to deliver, mind you send your wechat account to my email so that we can sync the progress & problem about the patch in time ? ) @anoopsjohn FYI.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
