[
https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926408#comment-16926408
]
Sakthi commented on HBASE-22796:
--------------------------------
+1 from me Stack.
Just a minor nit - There is a duplicate assertion in testIsOverlap:
{code:java}
@Test
public void testIsOverlap() {
assertTrue(MetaFixer.isOverlap(_BRI, new Pair<RegionInfo, RegionInfo>(ABRI,
ACRI)));
assertFalse(MetaFixer.isOverlap(_ARI, new Pair<RegionInfo, RegionInfo>(C_RI,
D_RI)));
assertTrue(MetaFixer.isOverlap(ADRI, new Pair<RegionInfo, RegionInfo>(CDRI,
C_RI)));
assertFalse(MetaFixer.isOverlap(_BRI, new Pair<RegionInfo, RegionInfo>(CDRI,
C_RI)));
assertFalse(MetaFixer.isOverlap(_BRI, new Pair<RegionInfo, RegionInfo>(CDRI,
C_RI))); // -> Duplicate
} {code}
> [HBCK2] Add fix of overlaps to fixMeta hbck Service
> ---------------------------------------------------
>
> Key: HBASE-22796
> URL: https://issues.apache.org/jira/browse/HBASE-22796
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Sakthi
> Priority: Major
> Attachments: HBASE-22796.master.001.patch,
> HBASE-22796.master.002.patch, HBASE-22796.master.003.patch,
> HBASE-22796.master.004.patch, HBASE-22796.master.005.patch
>
>
> fixMeta currently does holes in meta only courtesy of HBASE-22771 which added
> fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about
> adding fix of overlaps to general fixMeta call.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
