[
https://issues.apache.org/jira/browse/HBASE-23002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926472#comment-16926472
]
Peter Somogyi commented on HBASE-23002:
---------------------------------------
I started to test you commit on the branch after rebasing to the current
master. Few comments:
* hbase-assembly/src/main/assembly/bin.xml needs license header otherwise it
will fail on RAT check.
* might be good to rename hbase-assembly to hbase-operator-assembly not to
have naming conflict with the main hbase-assembly. HBase connectors use
hbase-connectors-assembly artifactId.
* In the generated tar.gz the hbase-hbck2-1.0.0-SNAPSHOT.jar is placed into
hbase-hbck2/*lib*/hbase-hbck2-1.0.0-SNAPSHOT.jar. Shouldn't it be under
hbase-hbck2/hbase-hbck2-1.0.0-SNAPSHOT.jar?
* lib contains slf4j-api-1.7.25.jar which is under MIT license. This is a
transitive dependency from log4j-slf4j-impl and I haven't noticed that we need
to package it. I will fix this one.
> [HBCK2/hbase-operator-tools] Create an assembly that builds an
> hbase-operator-tools tgz
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-23002
> URL: https://issues.apache.org/jira/browse/HBASE-23002
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Priority: Major
>
> Was going to build a convenience binary tgz as part of the first release of
> hbase-operator-tools. Not sure how just yet; best would be if it were a
> fatjar with all dependencies but that'd be kinda insane at same time since
> the tgz would be massive.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
