wchevreuil commented on a change in pull request #566: HBASE-22380 break circle
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/566#discussion_r323798172
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -579,9 +579,9 @@ public static BulkLoadHFileRequest
buildBulkLoadHFileRequest(
* @return a bulk load request
*/
public static BulkLoadHFileRequest buildBulkLoadHFileRequest(
- final List<Pair<byte[], String>> familyPaths,
- final byte[] regionName, boolean assignSeqNum,
- final Token<?> userToken, final String bulkToken, boolean copyFiles) {
+ final List<Pair<byte[], String>> familyPaths, final byte[] regionName,
boolean assignSeqNum,
+ final Token<?> userToken, final String bulkToken, boolean copyFiles,
+ List<String> clusterIds) {
Review comment:
_HRegionServer_ already keeps a _String_ clusterId (not UUID), which I'm
using to check against the incoming bulk load request. Converting the request
List<String> to List<UUID> when clusterId is already represented as String
didn't seem to give much gain here. Maybe we should raise a separate jira to
convert all existing String representations of cluster id into UUID, and
including this one as part of this work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
