virajjasani commented on a change in pull request #616: HBASE-23015 : Moving
from Jackson2 to shaded Gson (Backport HBASE-20587)
URL: https://github.com/apache/hbase/pull/616#discussion_r323793457
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
##########
@@ -52,11 +51,9 @@
* This class is not thread safe.
*/
@InterfaceAudience.Private
-@JsonIgnoreProperties({"indexStatistics", "freeSize", "usedSize"})
Review comment:
IndexStatistics is static class, freeSize is getter method: `public long
getFreeSize()` and usedSize is instance var of BucketAllocator and hence, only
that is made transient.
I am not sure how class and getter method can be prevented from
serialization as transient is not applied to them. Again, this change is inline
with branch-2.
Let me verify json with unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
