[ 
https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247399#comment-13247399
 ] 

Gary Helmling commented on HBASE-5451:
--------------------------------------

This change completely breaks SecureRpcEngine, which extended HBaseClient, 
HBaseServer, ConnectionHeader to share common functionality.  I think any 
changes to the RPC layer should be tested with "-P security" as well as without.

The org.apache.hadoop.hbase.security.User.createUser() addition also leaks out 
the previous User encapsulation of secure vs. non-secure UGI usage.  It seemed 
the majority was in favor of requiring Hadoop 1.0+ for HBase 0.96 in the dev 
list discussion, so I'm not sure this is a major issue.  But seems like it 
would be better for consistency to push the UGI calls down in to 
User.SecureHadoopUser.  Or we could discuss removing User.HadoopUser as cleanup 
in 0.96 if it's no longer supported.

Is there a plan with how the move the PB's integrates with security?
                
> Switch RPC call envelope/headers to PBs
> ---------------------------------------
>
>                 Key: HBASE-5451
>                 URL: https://issues.apache.org/jira/browse/HBASE-5451
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>    Affects Versions: 0.94.0
>            Reporter: Todd Lipcon
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 5305v7.txt, 5305v7.txt, rpc-proto.2.txt, 
> rpc-proto.3.txt, rpc-proto.patch.1_2, rpc-proto.r5.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to