busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623#discussion_r325776570
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ########## @@ -78,9 +84,15 @@ protected void chore() { } } } + // Now clean obsolete files for a table + LOG.info("Cleaning obsolete MOB files ..."); + MobUtils.cleanupObsoleteMobFiles(master.getConfiguration(), htd.getTableName()); Review comment: Why is the logic for this broken out into MobUtils? The only other uses I see are in test code that could just instantiate this chore instead of reimplementing it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services