busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r325957389
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -362,11 +508,375 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
abortWriter(mobFileWriter);
}
}
+ // Commit or abort generational writers
+ if (mobWriters != null) {
+ for (StoreFileWriter w: mobWriters.getOutputWriters()) {
+ Long mobs = mobWriters.getMobCountForOutputWriter(w);
+ if (mobs != null && mobs > 0) {
+ mobRefSet.get().add(w.getPath().getName());
+ w.appendMetadata(fd.maxSeqId, major, mobs);
+ w.close();
+ mobStore.commitFile(w.getPath(), path);
+ } else {
+ abortWriter(w);
+ }
+ }
+ }
mobStore.updateCellsCountCompactedFromMob(cellsCountCompactedFromMob);
mobStore.updateCellsCountCompactedToMob(cellsCountCompactedToMob);
mobStore.updateCellsSizeCompactedFromMob(cellsSizeCompactedFromMob);
mobStore.updateCellsSizeCompactedToMob(cellsSizeCompactedToMob);
progress.complete();
return true;
}
+
+ protected static String createKey(TableName tableName, String encodedName,
+ String columnFamilyName) {
+ return tableName.getNameAsString()+ "_" + encodedName + "_"+
columnFamilyName;
+ }
+
+ @Override
+ protected List<Path> commitWriter(StoreFileWriter writer, FileDetails fd,
+ CompactionRequestImpl request) throws IOException {
+ List<Path> newFiles = Lists.newArrayList(writer.getPath());
+ writer.appendMetadata(fd.maxSeqId, request.isAllFiles(),
request.getFiles());
+ // Append MOB references
+ Set<String> refSet = mobRefSet.get();
+ writer.appendMobMetadata(refSet);
+ writer.close();
+ return newFiles;
+ }
+
+ private List<Path> getReferencedMobFiles(Collection<HStoreFile> storeFiles) {
Review comment:
this should be in MobUtils so that we can reuse it later when updating the
mob integrity checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
