busbey commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r326695340
########## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestOperation.java ########## @@ -60,6 +59,9 @@ import org.apache.hadoop.hbase.testclassification.SmallTests; import org.apache.hadoop.hbase.util.BuilderStyleTest; import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.GsonUtil; +import org.apache.hbase.thirdparty.com.google.common.reflect.TypeToken; Review comment: just in general. the common.reflect package is from Guava. gson.reflect is from GSON. both just happen to be available in the hbase-thirdparty-miscellaneous artifact. it only came up in the jdk7 stuff because a couple of the options made it so relocated guava wasn't around anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
