busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r327299749
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java
##########
@@ -39,27 +39,33 @@
* mob files.
*/
@InterfaceAudience.Private
-public class ExpiredMobFileCleanerChore extends ScheduledChore {
+public class MobFileCleanerChore extends ScheduledChore {
Review comment:
I don't see any tests for
a) properly removing obsolete files as expected
b) not removing mob files from prior to the reference accounting added in
this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
