virajjasani commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r327724014
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetricsBuilder.java ########## @@ -358,6 +360,8 @@ public String toString() { for (RegionMetrics r : getRegionMetrics().values()) { storeCount += r.getStoreCount(); storeFileCount += r.getStoreFileCount(); + storeRefCount += r.getStoreRefCount(); + maxStoreFileRefCount += r.getMaxStoreFileRefCount(); Review comment: This is addition of all counts for toString() right? I thought of doing max() but somehow I feel all these counts should be addition of all regionMetrics for the sake of toString() only. Still, I agree better to include max of all storeFileRefCount ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services