petersomogyi commented on a change in pull request #592: HBASE-22982: region 
server suspend/resume and graceful rolling restart actions
URL: https://github.com/apache/hbase/pull/592#discussion_r328056666
 
 

 ##########
 File path: 
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/SlowDeterministicMonkeyFactory.java
 ##########
 @@ -128,56 +136,65 @@ public ChaosMonkey build() {
 
   private void loadProperties() {
 
-      action1Period = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.PERIODIC_ACTION1_PERIOD,
-        MonkeyConstants.DEFAULT_PERIODIC_ACTION1_PERIOD + ""));
-      action2Period = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.PERIODIC_ACTION2_PERIOD,
-        MonkeyConstants.DEFAULT_PERIODIC_ACTION2_PERIOD + ""));
-      action3Period = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.COMPOSITE_ACTION3_PERIOD,
-        MonkeyConstants.DEFAULT_COMPOSITE_ACTION3_PERIOD + ""));
-      action4Period = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.PERIODIC_ACTION4_PERIOD,
-        MonkeyConstants.DEFAULT_PERIODIC_ACTION4_PERIOD + ""));
-      moveRegionsMaxTime = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.MOVE_REGIONS_MAX_TIME,
-        MonkeyConstants.DEFAULT_MOVE_REGIONS_MAX_TIME + ""));
-      moveRegionsSleepTime = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.MOVE_REGIONS_SLEEP_TIME,
-        MonkeyConstants.DEFAULT_MOVE_REGIONS_SLEEP_TIME + ""));
-      moveRandomRegionSleepTime = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.MOVE_RANDOM_REGION_SLEEP_TIME,
-        MonkeyConstants.DEFAULT_MOVE_RANDOM_REGION_SLEEP_TIME + ""));
-      restartRandomRSSleepTime = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.RESTART_RANDOM_RS_SLEEP_TIME,
-        MonkeyConstants.DEFAULT_RESTART_RANDOM_RS_SLEEP_TIME + ""));
-      batchRestartRSSleepTime = Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.BATCH_RESTART_RS_SLEEP_TIME,
-        MonkeyConstants.DEFAULT_BATCH_RESTART_RS_SLEEP_TIME + ""));
-      batchRestartRSRatio = Float.parseFloat(this.properties.getProperty(
-        MonkeyConstants.BATCH_RESTART_RS_RATIO,
-        MonkeyConstants.DEFAULT_BATCH_RESTART_RS_RATIO + ""));
-      restartActiveMasterSleepTime = 
Long.parseLong(this.properties.getProperty(
-        MonkeyConstants.RESTART_ACTIVE_MASTER_SLEEP_TIME,
-        MonkeyConstants.DEFAULT_RESTART_ACTIVE_MASTER_SLEEP_TIME + ""));
-      rollingBatchRestartRSSleepTime = 
Long.parseLong(this.properties.getProperty(
+    action1Period = Long.parseLong(this.properties.getProperty(
 
 Review comment:
   Please do not reformat unrelated lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to