[
https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938747#comment-16938747
]
Michael Stack commented on HBASE-23054:
---------------------------------------
Patch looks nice. Appreciate the cleanup/simplification. Few nits:
s/LossyCountListener/LossyCountingListener/ to match name of its targetted
class.
Is this the algo fix? data.put(key, data.getOrDefault(key, currentTerm != 0 ?
currentTerm - 1 : 0) + 1); Add a comment? (W/o reading paper, I don't get it ).
nit. See how we have spacing in our code after ',' and after paren -- i.e. make
your additions look like the background code.
Thanks Ankit.
> Remove synchronization block from MetaTableMetrics and fix LossyCounting
> algorithm
> ----------------------------------------------------------------------------------
>
> Key: HBASE-23054
> URL: https://issues.apache.org/jira/browse/HBASE-23054
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.1.5
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Major
> Attachments: HBASE-23054.master.001.patch
>
>
> While trying to use LossyCounting for HBASE-15519 , found following bugs in
> current implementation
> – Remove synchronization block from MetaTableMetrics to avoid congestion at
> the code
> – Fix license format
> – Fix LossyCounting algorithm as per
> [http://www.vldb.org/conf/2002/S10P03.pdf
> |http://www.vldb.org/conf/2002/S10P03.pdf]
> -- Avoid doing sweep on every insert in LossyCounting
> – Remove extra redundant data structures from MetaTableMetrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
