anoopsjohn commented on a change in pull request #626: HBASE-23017 Verify the 
file integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/626#discussion_r329009236
 
 

 ##########
 File path: hbase-protocol-shaded/src/main/protobuf/BucketCacheEntry.proto
 ##########
 @@ -26,11 +26,12 @@ option java_generate_equals_and_hash = true;
 option optimize_for = SPEED;
 
 message BucketCacheEntry {
-  required int64 cache_capacity = 1;
-  required string io_class = 2;
-  required string map_class = 3;
-  map<int32, string> deserializers = 4;
-  required BackingMap backing_map = 5;
+  optional bytes checksum = 1;
 
 Review comment:
   Put checksum bytes as the last entry. Do not change the existing order.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to