Apache9 commented on a change in pull request #674: HBASE-23095 Reuse FileStatus in StoreFileInfo URL: https://github.com/apache/hbase/pull/674#discussion_r329445225
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ########## @@ -109,6 +111,11 @@ */ public StoreFileInfo(final Configuration conf, final FileSystem fs, final Path initialPath) throws IOException { + this(conf, fs, initialPath, null, null); + } + + private StoreFileInfo(final Configuration conf, final FileSystem fs, final Path initialPath, + final Long createdTimestamp, final Long size) throws IOException { Review comment: But this requires extra boxing/unboxing? And what if we need more parameters in the future... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services