karthikhw commented on a change in pull request #674: HBASE-23095 Reuse
FileStatus in StoreFileInfo
URL: https://github.com/apache/hbase/pull/674#discussion_r329710351
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##########
@@ -109,6 +111,11 @@
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath)
throws IOException {
+ this(conf, fs, initialPath, null, null);
+ }
+
+ private StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
+ final Long createdTimestamp, final Long size) throws IOException {
Review comment:
Thank you very much @anoopsjohn @Apache9. I used wrapped type because I
thought its good choice for a "null" check instead of checking whether
StoreFile length is 0 or more. sorry I may be wrong :) I understand Duo
concerns likely possible unboxing overhead for each conversion. Let me change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
