busbey commented on a change in pull request #42: HBASE-22817 Use hbase-shaded
dependencies in hbase-spark
URL: https://github.com/apache/hbase-connectors/pull/42#discussion_r329748976
##########
File path: pom.xml
##########
@@ -491,7 +514,7 @@
<artifactId>flatten-maven-plugin</artifactId>
<version>1.1.0</version>
<configuration>
- <updatePomFile>true</updatePomFile>
+ <updatePomFile>false</updatePomFile>
Review comment:
looking at this more locally, I think setting this to false also made it so
the plugin didn't put an updated pom into the repo as a result of running
`install`. It also looks like after the changes to wrap the maven plugin for
yetus we don't generate maven commands that cause the flatten plugin to fail
with this set to true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
