[ https://issues.apache.org/jira/browse/HBASE-23112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943313#comment-16943313 ]
Michael Stack commented on HBASE-23112: --------------------------------------- Yeah. That no longer holds. Will fix that too. Wondering if we should label usage with porcelain or plumbing tags or we should make a tool called 'fixMeta' and another called 'filesystem'; i.e. break out porcelain commands as standalone scripts? > [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was > plumbing; fix > ----------------------------------------------------------------------------------- > > Key: HBASE-23112 > URL: https://issues.apache.org/jira/browse/HBASE-23112 > Project: HBase > Issue Type: Bug > Components: hbase-operator-tools > Reporter: Michael Stack > Priority: Major > > From [~daisuke.kobayashi]: > {code} > Daisuke Kobayashi 6:45 PM > ... One confusion here is fixMeta in hbck1 was a plumbing command whereas the > new fixMeta in hbck2 is a porcelain command which fixes several issues behind > the scene. Wonder if it's a good naming. Sorry for bothering you! > if you don't wanna change the command name, it'd be better to have a clear > documentation. > {code} > How about we add note to usage that makes it clear it is not same as hbck1 > and in the README where we talk about difference between hbck1 and hbck2, we > talk up this command in particular; that users need to be careful expecting > hbck1 behaviors even in case where commands are similarly named? -- This message was sent by Atlassian Jira (v8.3.4#803005)